Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eas-cli] Upload package.json alongside eas.json when creating a workflow run #2786

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[eas-cli] Upload package.json alongside eas.json when creating a workflow run #2786

wants to merge 4 commits into from
+894 −249

Conversation

sjchmiela
Copy link
Contributor

@sjchmiela sjchmiela commented Dec 20, 2024 •
edited
Loading

Why

Thanks to @szdziedzic's changes to www, if we send a package.json along with eas.json when setting up a workflow run, EAS will pick the right images based on SDK and RN versions as eas build would.

How

Added uploading package.json after uploading eas.json, added the new argument to the mutation.

Test Plan

Tested manually.

Zrzut ekranu 2024-12-20 o 22 27 20 Zrzut ekranu 2024-12-20 o 22 27 58

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 20, 2024 •
edited
Loading

Size Change: +395 B (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB +395 B (0%)

compressed-size-action

@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 62.06897% with 11 lines in your changes missing coverage. Please review.

Project coverage is 52.52%. Comparing base (a1d086f) to head (ca6b538).

Files with missing lines Patch % Lines
...as-cli/src/project/uploadAccountScopedFileAsync.ts 47.06% 9 Missing ⚠️
packages/eas-cli/src/commands/workflow/run.ts 33.34% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2786      +/-   ##
==========================================
+ Coverage   52.51%   52.52%   +0.02%     
==========================================
  Files         583      583              
  Lines       22582    22589       +7     
  Branches     4452     4452              
==========================================
+ Hits        11856    11862       +6     
- Misses      10691    10692       +1     
  Partials       35       35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

✅ Thank you for adding the changelog entry!

@sjchmiela sjchmiela marked this pull request as ready for review December 20, 2024 21:34
@github-actions GitHub Actions
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @radoslawkrzemien

Generated by CodeMention

szdziedzic
szdziedzic approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@szdziedzic szdziedzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szdziedzic szdziedzic szdziedzic approved these changes

@jonsamp jonsamp Awaiting requested review from jonsamp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjchmiela @szdziedzic